git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] send-email: drop FakeTerm hack

From
Taylor Blau <me@ttaylorr.com>
Date
Aug 8, 2023, 20:13 UTC
Message-ID
<ZNKh2lzaRUjeU9AF@nand.local>
In-Reply-To
<20230808181436.GA2097200@coredump.intra.peff.net>
On Tue, Aug 08, 2023 at 02:14:36PM -0400, Jeff King wrote:
Show 9 quoted lines
> The smaller change is to implement:
>
>   sub IN { return undef }
>
> for FakeTerm, which would then behave according to 5906f54e47's "no tty"
> behavior. But after reading through the relevant history, I'm fairly
> convinced that just dropping it is the right path. If it were actually
> kicking in ever, people would be complaining about the obscure
> "$term->IN is not defined" error message from perl.
All makes sense. Thanks for the detailed commit message, as always :-).

Thanks, Taylor

Previous: Jeff King
Message 5 of 5 in “fix git-send-email with recent versions of Term::ReadLine::Gnu”
  1. 0/2 fix git-send-email with recent versions of Term::ReadLine::GnuJeff King, Aug 8, 2023
  2. 2/2 send-email: avoid creating more than one Term::ReadLine objectJeff King, Aug 8, 2023
  3. Taylor BlauAug 8, 2023
  4. 1/2 send-email: drop FakeTerm hackJeff King, Aug 8, 2023
  5. Taylor BlauAug 8, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.