git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] fix git-send-email with recent versions of Term::ReadLine::Gnu

From
Jeff King <peff@peff.net>
Date
Aug 8, 2023, 18:09 UTC
Message-ID
<20230808180935.GA2096901@coredump.intra.peff.net>

Using git-send-email with the latest release of Term::ReadLine::Gnu causes any invocations which prompt more than once to fail. Details are in the second patch, which fixes it. The first patch cleans up an obsolete workaround that obscured the root cause of the problem.

The affected version of Term::ReadLine::Gnu is v1.46, which hit Debian unstable in the past few weeks. So we should consider this for maint and perhaps even for the -rc candidates, since people will presumably start running into this more and more.

  [1/2]: send-email: drop FakeTerm hack
  [2/2]: send-email: avoid creating more than one Term::ReadLine object
 git-send-email.perl   | 32 +++++++++++---------------------
 t/t9001-send-email.sh |  5 +++--
 2 files changed, 14 insertions(+), 23 deletions(-)
-Peff
Next: Jeff King
Message 1 of 5 in “fix git-send-email with recent versions of Term::ReadLine::Gnu”
  1. 0/2 fix git-send-email with recent versions of Term::ReadLine::GnuJeff King, Aug 8, 2023
  2. 2/2 send-email: avoid creating more than one Term::ReadLine objectJeff King, Aug 8, 2023
  3. Taylor BlauAug 8, 2023
  4. 1/2 send-email: drop FakeTerm hackJeff King, Aug 8, 2023
  5. Taylor BlauAug 8, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.