From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 08 Aug 2023 20:13:14 GMT
Subject: Re: [PATCH 1/2] send-email: drop FakeTerm hack
Message-ID: <ZNKh2lzaRUjeU9AF@nand.local>
In-Reply-To: <20230808181436.GA2097200@coredump.intra.peff.net>

On Tue, Aug 08, 2023 at 02:14:36PM -0400, Jeff King wrote:
> The smaller change is to implement:
>
>   sub IN { return undef }
>
> for FakeTerm, which would then behave according to 5906f54e47's "no tty"
> behavior. But after reading through the relevant history, I'm fairly
> convinced that just dropping it is the right path. If it were actually
> kicking in ever, people would be complaining about the obscure
> "$term->IN is not defined" error message from perl.

All makes sense. Thanks for the detailed commit message, as always :-).

Thanks,
Taylor