jt/path-filter-fix (was: Re: What's cooking in git.git (Aug 2023, #01; Wed, 2))

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 2, 2023, 19:09 UTC
Message-ID: <ZMqp6K2iXixWH/zT@nand.local>
In-Reply-To: <xmqqfs518gdh.fsf@gitster.g>

On Wed, Aug 02, 2023 at 11:10:34AM -0700, Junio C Hamano wrote:

Show 16 quoted lines

> * jt/path-filter-fix (2023-08-01) 7 commits
>  - commit-graph: new filter ver. that fixes murmur3
>  - repo-settings: introduce commitgraph.changedPathsVersion
>  - t4216: test changed path filters with high bit paths
>  - t/helper/test-read-graph: implement `bloom-filters` mode
>  - bloom.h: make `load_bloom_filter_from_graph()` public
>  - t/helper/test-read-graph.c: extract `dump_graph_info()`
>  - gitformat-commit-graph: describe version 2 of BDAT
>
>  The Bloom filter used for path limited history traversal was broken
>  on systems whose "char" is unsigned; update the implementation and
>  bump the format version to 2.
>
>  Still under discussion.
>  cf. <20230801185232.1457172-1-jonathantanmy@google.com>
>  source: <cover.1690912539.git.jonathantanmy@google.com>

I am happy with the most recent round, but I think that it is probably a little late in the cycle to be merging down such a large change.

I wouldn't be opposed if you did so, but it may be worth waiting until we're on the other side of 2.42 so that other reviewers have a chance to look at this one as well.

Thanks, Taylor