git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: leak in jt/path-filter-fix, was Re: What's cooking in git.git (Aug 2023, #01; Wed, 2)

From
Jeff King <peff@peff.net>
Date
Aug 8, 2023, 21:19 UTC
Message-ID
<20230808211957.GB322409@coredump.intra.peff.net>
In-Reply-To
<ZNKj9vwZv4kKJEcL@nand.local>
On Tue, Aug 08, 2023 at 04:22:14PM -0400, Taylor Blau wrote:
Show 20 quoted lines
> On Tue, Aug 08, 2023 at 03:22:40PM -0400, Jeff King wrote:
> > Since this hit 'next', Coverity complained about a small leak. Fixed by
> > the patch below.
> 
> The patch below looks good and makes sense to me. That warning is
> awfully long, though ;-).
> 
> In any event, I expect that 'next' will be rewound before this topic
> graduates, since it is meaty and we are in the middle of the -rc phase.
> 
> ...and we also have my series on top [1], so it may be worthwhile for
> you, Jonathan, and I to figure out how to combine our efforts here. I
> think that this could likely get squashed in to Jonathan's topic
> if/after it gets ejected from 'next'. We can take my patches together in
> the same series, separately in a different one, or discard them
> altogether.
> 
> If we do decide to pursue the approach in [1], I think combining
> everything together into one big series makes the most sense for ease of
> merging.

Yeah, I am just coming back from vacation and didn't follow all of the discussion on this topic carefully. The few patches I sent today were just enough to get the test suite passing again (the send-email fixes) and silence any new Coverity warnings. ;)

If it does get re-rolled, I would be quite happy if my fix here just gets squashed into the appropriate commit.

-Peff
Previous: Taylor BlauNext: Jonathan Tan
Message 9 of 15 in “What's cooking in git.git (Aug 2023, #01; Wed, 2)”
  1. Junio C HamanoAug 2, 2023
  2. jt/path-filter-fix (was: Re: What's cooking in git.git (Aug 2023, #01; Wed, 2))Taylor Blau, Aug 2, 2023
  3. Junio C HamanoAug 2, 2023
  4. Taylor BlauAug 2, 2023
  5. Rubén JustoAug 7, 2023
  6. leak in jt/path-filter-fix, was Re: What's cooking in git.git (Aug 2023, #01; Wed, 2)Jeff King, Aug 8, 2023
  7. Jeff KingAug 8, 2023
  8. Taylor BlauAug 8, 2023
  9. Jeff KingAug 8, 2023
  10. Jonathan TanAug 11, 2023
  11. Christian CouderAug 7, 2023
  12. Junio C HamanoAug 7, 2023
  13. Taylor BlauAug 7, 2023
  14. Elijah NewrenAug 7, 2023
  15. Johannes SchindelinAug 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.