Re: [PATCH 2/9] builtin/verify-tag: stop using `the_repository`

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 20, 2025, 07:21 UTC
Message-ID: <Z9vCDFRUG7IzU_AG@pks.im>
In-Reply-To: <20250318115912.2978992-3-usmanakinyemi202@gmail.com>

On Tue, Mar 18, 2025 at 05:28:54PM +0530, Usman Akinyemi wrote:

Show 18 quoted lines

> diff --git a/t/t7030-verify-tag.sh b/t/t7030-verify-tag.sh
> index 6f526c37c2..2c147072c1 100755
> --- a/t/t7030-verify-tag.sh
> +++ b/t/t7030-verify-tag.sh
> @@ -7,6 +7,13 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
>  . ./test-lib.sh
>  . "$TEST_DIRECTORY/lib-gpg.sh"
>  
> +test_expect_success GPG 'verify-tag does not crash with -h' '
> +	test_expect_code 129 git verify-tag -h >usage &&
> +	test_grep "[Uu]sage: git verify-tag " usage &&
> +	test_expect_code 129 nongit git verify-tag -h >usage &&
> +	test_grep "[Uu]sage: git verify-tag " usage
> +'
> +
>  test_expect_success GPG 'create signed tags' '
>  	echo 1 >file && git add file &&
>  	test_tick && git commit -m initial &&

We have "t1517-outside-repo.sh". Maybe it would preferable to add tests like these to that test suite instead?

Patrick