Re: [PATCH 9/9] builtin/update-server-info: remove unnecessary if statement

From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Mar 21, 2025, 07:00 UTC
Message-ID: <CAPSxiM8i=BRsn=7E5e28T1HndebefzrE8nuwZ0CdN+P+YymV4w@mail.gmail.com>
In-Reply-To: <Z9vCCfZJBsyp8Y3-@pks.im>

On Thu, Mar 20, 2025 at 12:51 PM Patrick Steinhardt <ps@pks.im> wrote:

Show 17 quoted lines

>
> On Tue, Mar 18, 2025 at 05:29:01PM +0530, Usman Akinyemi wrote:
> > Since we already teach the `repo_config()` to allow `repo`
> > to be NULL, no need to check if `repo` is NULL before calling
> > `repo_config()`.
>
> I think it would be preferable to reorder this patch so that it comes
> immediately after the one where you adapt `repo_config()`.
>
> We also have a couple of additional sites where we call the function
> conditionally:
>
>   - builtin/add.c
>   - builtin/difftool.c
>   - builtin/update-server-info.c
>
> It would probably make sense to also adapt those.

Yeah, it has caused a little confusion. Maybe, let's just ignore this patch series.

The other series which introduces the first 8 patches of this has been marked to be merged to master. I will resend the 9th patch( builtin/update-server-info.c) then other functions like difftool.

Thank you.

>
> Patrick