Re: [PATCH 9/9] builtin/update-server-info: remove unnecessary if statement
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Mar 20, 2025, 07:21 UTC
- Message-ID
- <Z9vCCfZJBsyp8Y3-@pks.im>
- In-Reply-To
- <20250318115912.2978992-10-usmanakinyemi202@gmail.com>
On Tue, Mar 18, 2025 at 05:29:01PM +0530, Usman Akinyemi wrote:
> Since we already teach the `repo_config()` to allow `repo` > to be NULL, no need to check if `repo` is NULL before calling > `repo_config()`.
I think it would be preferable to reorder this patch so that it comes immediately after the one where you adapt `repo_config()`.
We also have a couple of additional sites where we call the function conditionally:
- builtin/add.c - builtin/difftool.c - builtin/update-server-info.c
It would probably make sense to also adapt those.
Patrick