Re: [PATCH v1 1/4] t: introduce WITH_BREAKING_CHANGES prerequisite

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 11, 2025, 12:57 UTC
Message-ID: <Z9AzKoWLeOJ63j_E@pks.im>
In-Reply-To: <20250310231652.3742490-2-gitster@pobox.com>

On Mon, Mar 10, 2025 at 04:16:49PM -0700, Junio C Hamano wrote:

Show 16 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 9001ed3a64..12fe82f660 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1862,6 +1862,11 @@ test_lazy_prereq CURL '
>  	curl --version
>  '
>  
> +test_lazy_prereq WITH_BREAKING_CHANGES '
> +	test -n "$WITH_BREAKING_CHANGES"
> +'
> +
> +# DEPRECATED; DO NOT USE THIS IN NEW TESTS
>  test_lazy_prereq WITHOUT_BREAKING_CHANGES '
>  	test -z "$WITH_BREAKING_CHANGES"
>  '

Do we maybe want to state that this can be removed once the next release cycle is over? I find it to be a bit more actionable when stating hard dates after which something can be dropped as it allows any drive-by developers to act when they notice that Git v2.50 has been released already.

Patrick