git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/6] drop "name-rev --stdin" support

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 11, 2025, 21:24 UTC
Message-ID
<20250311212505.2920181-1-gitster@pobox.com>
In-Reply-To
<20250310231652.3742490-1-gitster@pobox.com>

During Git 2.40 timeframe, we deprecated the "--stdin" option of the "name-rev" command in preference to the "--annotate-stdin" option, and removed the mention of the former from the documentation.

Let's prepare for Git 3.0 to stop supporting it.

The real motive of these patches is not really about that particular option but make sure we have, with WITH_BREAKING_CHANGES compilation knob, enough support to keep preparing for these changes.

The first two patches are preliminary clean-up and enhancement. We lacked documentation on test_lazy_prereq and we did not have a good way to signal a prerequisite that no longer should be used, both of which are remedied.

The third patch renames the WITHOUT_BREAKING_CHANGES prerequisite that unfortunately invites double negations easily and changes existing users of it.

Then two patches to a test script minimally modernizes it.  

The last step introduces the real change, guarded by WITH_BREAKING_CHANGES compilation knob. The resulting code is more littered with #if[n]def compared to the previous round but it should be clear which section of the code should go away once we do Git 3.0, which is the whole point of the WITH_BREAKING_CHANGES exercise.

Junio C Hamano (6):
  t: document test_lazy_prereq
  t: extend test_lazy_prereq
  t: introduce WITH_BREAKING_CHANGES prerequisite
  t6120: avoid hiding "git" exit status
  t6120: further modernize
  name-rev: remove "--stdin" support
 Documentation/BreakingChanges.adoc |  6 ++++++
 builtin/name-rev.c                 | 10 +++++++++-
 t/README                           | 25 ++++++++++++++++++++++++-
 t/t5323-pack-redundant.sh          |  2 +-
 t/t5505-remote.sh                  |  6 +++---
 t/t5515-fetch-merge-logic.sh       |  2 +-
 t/t5516-fetch-push.sh              |  8 ++++----
 t/t6120-describe.sh                | 18 +++++++++++++-----
 t/test-lib-functions.sh            |  5 +++++
 t/test-lib.sh                      |  7 ++++++-
 10 files changed, 72 insertions(+), 17 deletions(-)
-- 
2.49.0-rc2-181-g28e223d67e
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 20 in “drop "name-rev --stdin" support”
  1. 0/4 drop "name-rev --stdin" supportJunio C Hamano, Mar 10, 2025
  2. 1/4 t: introduce WITH_BREAKING_CHANGES prerequisiteJunio C Hamano, Mar 10, 2025
  3. Eric SunshineMar 10, 2025
  4. Patrick SteinhardtMar 11, 2025
  5. Junio C HamanoMar 11, 2025
  6. 2/4 t6120: avoid hiding "git" exit statusJunio C Hamano, Mar 10, 2025
  7. 3/4 t6120: further modernizeJunio C Hamano, Mar 10, 2025
  8. 4/4 name-rev: remove "--stdin" supportJunio C Hamano, Mar 10, 2025
  9. Patrick SteinhardtMar 11, 2025
  10. Junio C HamanoMar 11, 2025
  11. 0/6 drop "name-rev --stdin" supportJunio C Hamano, Mar 11, 2025
  12. 1/6 t: document test_lazy_prereqJunio C Hamano, Mar 11, 2025
  13. 2/6 t: extend test_lazy_prereqJunio C Hamano, Mar 11, 2025
  14. Patrick SteinhardtMar 12, 2025
  15. Junio C HamanoMar 13, 2025
  16. 3/6 t: introduce WITH_BREAKING_CHANGES prerequisiteJunio C Hamano, Mar 11, 2025
  17. Patrick SteinhardtMar 12, 2025
  18. 4/6 t6120: avoid hiding "git" exit statusJunio C Hamano, Mar 11, 2025
  19. 5/6 t6120: further modernizeJunio C Hamano, Mar 11, 2025
  20. 6/6 name-rev: remove "--stdin" supportJunio C Hamano, Mar 11, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.