[PATCH v2 5/6] t6120: further modernize
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 11, 2025, 21:25 UTC
- Message-ID
- <20250311212505.2920181-6-gitster@pobox.com>
- In-Reply-To
- <20250311212505.2920181-1-gitster@pobox.com>
There is absolutely no reason why a pattern given to grep to find 'warning: --stdin is deprecated' must be quoted within a pair of single quotes, or the pattern to look for the literal string as ERE.
Quote the test body with a pair of single quotes like everybody else, and quote the needle string in a pair of double quotes. Also use test_grep instead of "grep -E".
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t6120-describe.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index dcb526e37d..71e261394a 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -298,11 +298,11 @@ test_expect_success 'name-rev --annotate-stdin' ' test_cmp expect actual ' -test_expect_success 'name-rev --stdin deprecated' " +test_expect_success 'name-rev --stdin deprecated' ' git rev-list --all >list && git name-rev --stdin <list 2>actual && - grep -E 'warning: --stdin is deprecated' actual -" + test_grep "warning: --stdin is deprecated" actual +' test_expect_success 'describe --contains with the exact tags' ' echo "A^0" >expect &&
-- 2.49.0-rc2-181-g28e223d67e