Re: [PATCH v4 05/16] refs/reftable: batch refname availability checks
On Thu, Mar 06, 2025 at 09:12:41AM -0500, Karthik Nayak wrote:
Show 17 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
> > Patrick Steinhardt <ps@pks.im> writes:
> >
> >> Refactor the "reftable" backend to batch the availability check for
> >> refnames. This does not yet have an effect on performance as we
> >> essentially still call `refs_verify_refname_available()` in a loop, but
> >> this will change in subsequent commits.
> >>
> >
> > I thought this patch removes it from the loop. Which loop are you
> > talking about?
> >
>
> Looking at future patches, maybe this 'loop' is a reference to how
> 'refs_verify_refnames_available()' still loops over all references,
> which we start optimizing in patch 08 and onward?
Yes, exactly. I'll clarify.
Patrick