Re: [PATCH 10/14] refs/iterator: implement seeking for reftable iterators

From: Karthik Nayak <karthik.188@gmail.com>
Date: Feb 19, 2025, 20:13 UTC
Message-ID: <CAOLa=ZSgpeTCayxCs01hdVJ3FsXMPCzSg+RV5tgMc0Agz9nAqg@mail.gmail.com>
In-Reply-To: <20250217-pks-update-ref-optimization-v1-10-a2b6d87a24af@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> Implement seeking of reftable iterators. As the low-level reftable
> iterators already support seeking this change is straight-forward. Two
> notes though:
>
>   - We do not support seeking on reflog iterators.
>

Nit: this doesn't explain the reason and it would be nice to state why
we do not support reflog iterators here

>   - We start to check whether `reftable_stack_init_ref_iterator()` is
>     successful.
>

The patch looks good!

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.