Re: [PATCH v2 02/16] object-name: allow skipping ambiguity checks in `get_oid()` family

From: Jeff King <peff@peff.net>
Date: Feb 21, 2025, 09:06 UTC
Message-ID: <20250221090625.GA2518234@coredump.intra.peff.net>
In-Reply-To: <Z7g69C7Y-CXIUrRn@pks.im>

On Fri, Feb 21, 2025 at 09:36:04AM +0100, Patrick Steinhardt wrote:

> Spoiler alert: I do have a patch series locally that gets rid of the
> global variable completely, and that series builds on top of the new
> flag I'm introducing here. So I'd prefer to keep it so that we can
> eventually have less callsites that rely on global state.

OK. I do agree that getting rid of the global would be nice. I just wasn't sure how ugly it would be to pass the flags through the stack into handle_revision().

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.