Re: [PATCH 06/10] unpack_loose_header(): avoid numeric comparison of zlib status

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 28, 2025, 00:32 UTC
Message-ID: <Z8EEGd4Q+Py3Ym0l@nand.local>
In-Reply-To: <20250225063056.GF1293961@coredump.intra.peff.net>

On Tue, Feb 25, 2025 at 01:30:56AM -0500, Jeff King wrote:

Show 12 quoted lines

> diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
> index e493600aff..86a2825473 100755
> --- a/t/t1006-cat-file.sh
> +++ b/t/t1006-cat-file.sh
> @@ -951,6 +951,8 @@ test_expect_success 'object reading handles zlib dictionary' - <<\EOT
>  	printf '\170\273\017\112\003\143' >$objpath &&
>
>  	test_must_fail git cat-file blob $blob 2>err &&
> +	test_grep ! 'too long' err &&
> +	test_grep 'error: unable to unpack' err &&
>  	test_grep 'error: inflate: needs dictionary' err
>  EOT

All looking good here, too.

I think the test_grep is hiding what is a fairly unpleasant error message that says the same thing a few times from different points in the call-stack. But that isn't anything new from this series, and I'm content to let it be a problem for another day ;-).

Thanks, Taylor