Re: [PATCH v4 3/6] version: make redact_non_printables() non-static

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 30, 2025, 10:51 UTC
Message-ID: <Z5tZpmmNpjC5-uFH@pks.im>
In-Reply-To: <20250127151701.2321341-4-christian.couder@gmail.com>

On Mon, Jan 27, 2025 at 04:16:58PM +0100, Christian Couder wrote:

> As we are going to reuse redact_non_printables() outside "version.c",
> let's make it non-static.

Missing the DCO.

Show 18 quoted lines

> diff --git a/version.h b/version.h
> index 7c62e80577..fcc1816685 100644
> --- a/version.h
> +++ b/version.h
> @@ -4,7 +4,15 @@
>  extern const char git_version_string[];
>  extern const char git_built_from_commit_string[];
>  
> +struct strbuf;
> +
>  const char *git_user_agent(void);
>  const char *git_user_agent_sanitized(void);
>  
> +/*
> + * Trim and replace each character with ascii code below 32 or above
> + * 127 (included) using a dot '.' character.
> +*/
> +void redact_non_printables(struct strbuf *buf);

Is this header really the right spot though? If I want to redact characters I certainly wouldn't be looking at "version.h" for that functionality.

Patrick