Re: [PATCH v3 00/10] compat/zlib: allow use of zlib-ng as backend
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jan 17, 2025, 11:02 UTC
- Message-ID
- <Z4o43deLB0-Kcxid@pks.im>
- In-Reply-To
- <CAOLa=ZSfhDHd65D3d6pxbG0HqMPobfdj8fRhLogANyJ_karz0w@mail.gmail.com>
On Fri, Jan 17, 2025 at 10:06:48AM +0000, Karthik Nayak wrote:
Show 25 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > > 9: 45fde7a7dd ! 9: 6fefd3ab44 ci: switch linux-musl to use Meson > > @@ Commit message > > is the `GIT_TEST_UTF8_LOCALE` variable used in tests. Wire up a build > > option for it, which we set via a new "MESONFLAGS" environment variable. > > > > + Note that we also drop the CC variable, which is set to "gcc". We > > + already default to GCC when CC is unset in "ci/lib.sh", so this is not > > + needed. > > + > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > > > > ## .github/workflows/main.yml ## > > @@ ci/lib.sh: linux32) > > > > ## ci/run-build-and-tests.sh ## > > @@ ci/run-build-and-tests.sh: case "$jobname" in > > - group "Configure" meson setup build . \ > > + --fatal-meson-warnings \ > > --warnlevel 2 --werror \ > > --wrap-mode nofallback \ > > - -Dfuzzers=true > > > > why remove the group here? The rest of the range-diff looks good.
I don't, it just fell out of the diff context and thus isn't seen anymore :) The line still exists.
Patrick