Re: [PATCH v2 09/10] ci: switch linux-musl to use Meson

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 15, 2025, 16:53 UTC
Message-ID: <Z4fn_cTzEl_vZ_Rw@pks.im>
In-Reply-To: <CAOLa=ZRiRWubZJHvzgag8Ypaeye_xzZ9e5bdZxRBQFL_qhzb1Q@mail.gmail.com>

On Wed, Jan 15, 2025 at 04:25:58PM +0000, Karthik Nayak wrote:

Show 17 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> [snip]
> 
> > diff --git a/ci/lib.sh b/ci/lib.sh
> > index 8885ee3c3f86c62e8783d27756b8779bd491e7e6..71d85ae85a02e5a4389e133ed53f45a5042af36e 100755
> > --- a/ci/lib.sh
> > +++ b/ci/lib.sh
> > @@ -378,10 +378,7 @@ linux32)
> >  	CC=gcc
> >  	;;
> >  linux-musl)
> > -	CC=gcc
> 
> Question: isn't this still needed? I thought there was no way to specify
> the default compiler in meson and as such it is better to be explicit
> about which compiler we want to use.

We already default to GCC anyway in "ci/lib.sh", as we have equivalents to the following for all CI systems:

	CC="${CC_PACKAGE:-${CC:-gcc}}"

I'll mention this in the commit message.

Patrick