Re: [PATCH v2 00/10] compat/zlib: allow use of zlib-ng as backend

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 15, 2025, 05:45 UTC
Message-ID: <Z4dLeyF8N8PhYAZq@pks.im>
In-Reply-To: <xmqqa5bt2jc8.fsf@gitster.g>

On Tue, Jan 14, 2025 at 01:09:43PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> One request.  You seem to have started using --full-index when
> generating the patches.  It is extremely annoying when a patch needs
> to be mucked with an editor to inspect why it does not apply and to
> tweak it to make it apply.  40-hex does not help at all if the base
> commit is not conveyed correctly, as the recipient will not have the
> necessary blob objects _anyway_.  And 40-hex is unnecessarily long
> in order to protect the recipient who uses "--3way" from using a
> wrong blob in a fake ancestor tree.  Please stop.

I have in fact started using b4, as it makes most of the tedious housekeeping around patch series go away, and it indeed uses `--full-index` to generate patches. There isn't any way to change that, but I'll send a patch upstream that gives us an option to do so.

My last patches haven't gotten any feedback though, so let's see how it goes.

Patrick