git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t7110: replace `test -f` with `test_path_is_*` helpers

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 3, 2025, 13:12 UTC
Message-ID
<Z3fiREGwXdILl-M1@pks.im>
In-Reply-To
<20250103130035.79376-1-matteobagnolini2003@gmail.com>
On Fri, Jan 03, 2025 at 02:00:35PM +0100, Matteo Bagnolini wrote:
Show 10 quoted lines
> From: matteobagnolini <matteobagnolini2003@gmail.com>
> 
> `test -f` and `! test -f` do not provide clear error messages when they fail.
> To enhance debuggability, use `test_path_is_file` and `test_path_is_missing`,
> which instead provide more informative error messages.
> 
> Note that `! test -f` checks if a path is not a file, while
> `test_path_is_missing` verifies that a path does not exist. In this specific
> case the tests are meant to check the absence of the path, making
> `test_path_is_missing` a valid replacement.
Thanks, this version looks good to me.
Patrick
Previous: Matteo BagnoliniNext: Junio C Hamano
Message 4 of 8 in “t7110: Replace `test -f` and `! test -f` with `test_path_is_file` and `test_path_is_missing` for improved debuggability when failing.”
  1. t7110: Replace `test -f` and `! test -f` with `test_path_is_file` and `test_path_is_missing` for improved debuggability when failing.matteobagnolini, Jan 1, 2025
  2. Patrick SteinhardtJan 3, 2025
  3. t7110: replace `test -f` with `test_path_is_*` helpersMatteo Bagnolini, Jan 3, 2025
  4. Patrick SteinhardtJan 3, 2025
  5. Junio C HamanoJan 3, 2025
  6. Matteo BagnoliniJan 3, 2025
  7. Junio C HamanoJan 3, 2025
  8. Matteo BagnoliniJan 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.