From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 03 Jan 2025 13:12:36 GMT
Subject: Re: [PATCH v2] t7110: replace `test -f` with `test_path_is_*` helpers
Message-ID: <Z3fiREGwXdILl-M1@pks.im>
In-Reply-To: <20250103130035.79376-1-matteobagnolini2003@gmail.com>

On Fri, Jan 03, 2025 at 02:00:35PM +0100, Matteo Bagnolini wrote:
> From: matteobagnolini <matteobagnolini2003@gmail.com>
> 
> `test -f` and `! test -f` do not provide clear error messages when they fail.
> To enhance debuggability, use `test_path_is_file` and `test_path_is_missing`,
> which instead provide more informative error messages.
> 
> Note that `! test -f` checks if a path is not a file, while
> `test_path_is_missing` verifies that a path does not exist. In this specific
> case the tests are meant to check the absence of the path, making
> `test_path_is_missing` a valid replacement.

Thanks, this version looks good to me.

Patrick