git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t7110: replace `test -f` with `test_path_is_*` helpers

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 3, 2025, 18:06 UTC
Message-ID
<xmqq7c7bsrel.fsf@gitster.g>
In-Reply-To
<CADyPGv0T7Wwrf_FidWDtLGOH7A88DcisAG4-jU3eEax106XEcQ@mail.gmail.com>
Matteo Bagnolini <matteobagnolini2003@gmail.com> writes:
Show 12 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Patrick Steinhardt <ps@pks.im> writes:
>>
>> > On Fri, Jan 03, 2025 at 02:00:35PM +0100, Matteo Bagnolini wrote:
>> >> From: matteobagnolini <matteobagnolini2003@gmail.com>
>>
>> This must match the author ident on the Signed-off-by: line.
>
> So should I send another patch with this correction?
> Sorry for questioning, but as you might have noticed, this is my first time
> contributing and I'm slowly trying to learn the process.

Thanks for asking; if there are no other things that need fixing, I can fix up while queuing.

Previous: Matteo BagnoliniNext: Matteo Bagnolini
Message 7 of 8 in “t7110: Replace `test -f` and `! test -f` with `test_path_is_file` and `test_path_is_missing` for improved debuggability when failing.”
  1. t7110: Replace `test -f` and `! test -f` with `test_path_is_file` and `test_path_is_missing` for improved debuggability when failing.matteobagnolini, Jan 1, 2025
  2. Patrick SteinhardtJan 3, 2025
  3. t7110: replace `test -f` with `test_path_is_*` helpersMatteo Bagnolini, Jan 3, 2025
  4. Patrick SteinhardtJan 3, 2025
  5. Junio C HamanoJan 3, 2025
  6. Matteo BagnoliniJan 3, 2025
  7. Junio C HamanoJan 3, 2025
  8. Matteo BagnoliniJan 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.