Re: [PATCH 03/10] ci: exercise unsafe OpenSSL backend
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Dec 30, 2024, 17:31 UTC
- Message-ID
- <Z3LY9gLVdQQWk0Zc@nand.local>
- In-Reply-To
- <20241230-pks-meson-sha1-unsafe-v1-3-efb276e171f5@pks.im>
On Mon, Dec 30, 2024 at 03:24:03PM +0100, Patrick Steinhardt wrote:
Show 23 quoted lines
> In the preceding commit we have fixed a segfault when using an unsafe > SHA1 backend that is different from the safe one. This segfault only > went by unnoticed because we never set up an unsafe backend in our CI > systems. Fix this ommission by setting `OPENSSL_SHA1_UNSAFE` in our > TEST-vars job. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > ci/run-build-and-tests.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh > index c4a41bba0b84df57f6e60aeac2de29dbc0e27dc1..76667a1277720d74e09e8da227b5e0832003e0e2 100755 > --- a/ci/run-build-and-tests.sh > +++ b/ci/run-build-and-tests.sh > @@ -17,6 +17,7 @@ linux-gcc) > export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main > ;; > linux-TEST-vars) > + export OPENSSL_SHA1_UNSAFE=YesPlease > export GIT_TEST_SPLIT_INDEX=yes > export GIT_TEST_MERGE_ALGORITHM=recursive > export GIT_TEST_FULL_IN_PACK_ARRAY=true
I think that this is a great idea, thanks for adding it!
Thanks, Taylor