git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 03/10] ci: exercise unsafe OpenSSL backend

From
Taylor Blau <me@ttaylorr.com>
Date
Dec 30, 2024, 17:31 UTC
Message-ID
<Z3LY9gLVdQQWk0Zc@nand.local>
In-Reply-To
<20241230-pks-meson-sha1-unsafe-v1-3-efb276e171f5@pks.im>
On Mon, Dec 30, 2024 at 03:24:03PM +0100, Patrick Steinhardt wrote:
Show 23 quoted lines
> In the preceding commit we have fixed a segfault when using an unsafe
> SHA1 backend that is different from the safe one. This segfault only
> went by unnoticed because we never set up an unsafe backend in our CI
> systems. Fix this ommission by setting `OPENSSL_SHA1_UNSAFE` in our
> TEST-vars job.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  ci/run-build-and-tests.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> index c4a41bba0b84df57f6e60aeac2de29dbc0e27dc1..76667a1277720d74e09e8da227b5e0832003e0e2 100755
> --- a/ci/run-build-and-tests.sh
> +++ b/ci/run-build-and-tests.sh
> @@ -17,6 +17,7 @@ linux-gcc)
>  	export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
>  	;;
>  linux-TEST-vars)
> +	export OPENSSL_SHA1_UNSAFE=YesPlease
>  	export GIT_TEST_SPLIT_INDEX=yes
>  	export GIT_TEST_MERGE_ALGORITHM=recursive
>  	export GIT_TEST_FULL_IN_PACK_ARRAY=true
I think that this is a great idea, thanks for adding it!

Thanks, Taylor

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 12 of 19 in “Fix segfaults when using the unsafe SHA1 backend”
  1. 00/10 Fix segfaults when using the unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  2. 02/10 builtin/fast-import: fix segfault with unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  3. Taylor BlauDec 30, 2024
  4. Patrick SteinhardtJan 3, 2025
  5. Junio C HamanoJan 3, 2025
  6. Taylor BlauJan 6, 2025
  7. Patrick SteinhardtJan 7, 2025
  8. Taylor BlauJan 8, 2025
  9. Patrick SteinhardtJan 9, 2025
  10. 01/10 bulk-checkin: fix segfault with unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  11. 03/10 ci: exercise unsafe OpenSSL backendPatrick Steinhardt, Dec 30, 2024
  12. Taylor BlauDec 30, 2024
  13. 04/10 meson: consistenlty spell 'CommonCrypto'Patrick Steinhardt, Dec 30, 2024
  14. 05/10 meson: deduplicate access to SHA1/SHA256 backend optionsPatrick Steinhardt, Dec 30, 2024
  15. 06/10 meson: require SecurityFramework when it's used as SHA1 backendPatrick Steinhardt, Dec 30, 2024
  16. 07/10 meson: simplify conditions for HTTPS and SHA1 dependenciesPatrick Steinhardt, Dec 30, 2024
  17. 08/10 meson: add missing dots for build optionsPatrick Steinhardt, Dec 30, 2024
  18. 09/10 meson: wire up unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  19. 10/10 meson: provide a summary of configured backendsPatrick Steinhardt, Dec 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.