git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 00/10] Fix segfaults when using the unsafe SHA1 backend

From
Patrick Steinhardt <ps@pks.im>
Date
Dec 30, 2024, 14:24 UTC
Message-ID
<20241230-pks-meson-sha1-unsafe-v1-0-efb276e171f5@pks.im>
Hi,

this patch series fixes two segfaults when using the unsafe SHA1 backend. The segfaults are caused by us mixing safe and unsafe variants of the API. As such, it only surfaces when actually building Git with an unsafe backend that is different from the safe one.

I noticed those errors while wiring up the build option in the Meson build system. As such, this patch series doesn't only fix the segfaults, but also includes patches for the Meson infrastructure and is structured as follows:

  - Patches 1 and 2 fix the segfaults.
  - Patch 3 makes the segfaults visible via our CI.
  - Patches 4 to 10 wire up the build infrastructure in Meson.

Given that we're close to the release of Git v2.48 I'd be fine with merging just the first three patches. I can then re-send the Meson stuff early in the next development cycle.

Thanks!
Patrick
---
Patrick Steinhardt (10):
      bulk-checkin: fix segfault with unsafe SHA1 backend
      builtin/fast-import: fix segfault with unsafe SHA1 backend
      ci: exercise unsafe OpenSSL backend
      meson: consistenlty spell 'CommonCrypto'
      meson: deduplicate access to SHA1/SHA256 backend options
      meson: require SecurityFramework when it's used as SHA1 backend
      meson: simplify conditions for HTTPS and SHA1 dependencies
      meson: add missing dots for build options
      meson: wire up unsafe SHA1 backend
      meson: provide a summary of configured backends
 builtin/fast-import.c     |  2 +-
 bulk-checkin.c            |  2 +-
 ci/run-build-and-tests.sh |  1 +
 meson.build               | 51 ++++++++++++++++++++++++++++++++++++-----------
 meson_options.txt         |  8 +++++---
 5 files changed, 47 insertions(+), 17 deletions(-)

--- base-commit: 306ab352f4e98f6809ce52fc4e5d63fb947d0635 change-id: 20241230-pks-meson-sha1-unsafe-03c785824eee

Next: Patrick Steinhardt
Message 1 of 19 in “Fix segfaults when using the unsafe SHA1 backend”
  1. 00/10 Fix segfaults when using the unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  2. 02/10 builtin/fast-import: fix segfault with unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  3. Taylor BlauDec 30, 2024
  4. Patrick SteinhardtJan 3, 2025
  5. Junio C HamanoJan 3, 2025
  6. Taylor BlauJan 6, 2025
  7. Patrick SteinhardtJan 7, 2025
  8. Taylor BlauJan 8, 2025
  9. Patrick SteinhardtJan 9, 2025
  10. 01/10 bulk-checkin: fix segfault with unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  11. 03/10 ci: exercise unsafe OpenSSL backendPatrick Steinhardt, Dec 30, 2024
  12. Taylor BlauDec 30, 2024
  13. 04/10 meson: consistenlty spell 'CommonCrypto'Patrick Steinhardt, Dec 30, 2024
  14. 05/10 meson: deduplicate access to SHA1/SHA256 backend optionsPatrick Steinhardt, Dec 30, 2024
  15. 06/10 meson: require SecurityFramework when it's used as SHA1 backendPatrick Steinhardt, Dec 30, 2024
  16. 07/10 meson: simplify conditions for HTTPS and SHA1 dependenciesPatrick Steinhardt, Dec 30, 2024
  17. 08/10 meson: add missing dots for build optionsPatrick Steinhardt, Dec 30, 2024
  18. 09/10 meson: wire up unsafe SHA1 backendPatrick Steinhardt, Dec 30, 2024
  19. 10/10 meson: provide a summary of configured backendsPatrick Steinhardt, Dec 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.