Re: [PATCH 2/3] log: add default decoration filter

From: Jeff King <peff@peff.net>
Date: Jul 29, 2022, 20:32 UTC
Message-ID: <YuRD9Uu/yAGg6roj@coredump.intra.peff.net>
In-Reply-To: <xmqqczdqtxro.fsf@gitster.g>

On Wed, Jul 27, 2022 at 07:50:51AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> > * Notes (refs/notes/)
> 
> Questionable.  None of the notes commits are on the primary history,
> so it is unlikely to be even used for decoration, so it would not
> hurt to have them as part of possible decoration sources, but on the
> other hand, the value of using them is dubious.
> 
> > * Stashes (refs/stash/)
> 
> Questionable, for the same reason as 'notes'.

Even more so, IMHO, because we are not even decorating all of the stashes. Because the stash is kept in a reflog, it is really just decorating stash@{0}.

As you said elsewhere, I'm OK with keeping it in the name of "it's probably not hurting", but I'd be really surprised if it has ever helped anyone.

-Peff