Re: [PATCH 2/3] t0033-safe-directory: check when 'safe.directory' is ignored

From: Taylor Blau <me@ttaylorr.com>
Date: May 10, 2022, 20:11 UTC
Message-ID: <YnrHDieIQqjBUl/2@nand.local>
In-Reply-To: <20220510200658.n2ythd5soyzguqb4@carlos-mbp.lan>

On Tue, May 10, 2022 at 01:06:58PM -0700, Carlo Marcelo Arenas Belón wrote:

Show 17 quoted lines

> On Tue, May 10, 2022 at 03:55:23PM -0400, Taylor Blau wrote:
> > > >
> > > > 	GIT_TEST_ASSUME_DIFFERENT_USER=0 git config --unset safe.directory
> > >
> > > Oh, wow.  This is so obvious, no wonder it didn't occur to me :)
> >
> > Don't we consider this one-shot environment variable to be sticky on
> > some shells (i.e., that it persists beyond just the "git config"
> > invocation here)?
>
> do you have an example of such a shell?, I would assume that since the
> mechanism to implement these would be similar to local and we already
> require local for running our tests, that shouldn't be an issue (at
> least in the test suite), right?
>
> any such variables should be only set as part of the environment used
> by the posix shell before it call execve to invoke the next command IMHO.

This is completely my mistake, that stickiness exists only when invoking shell _functions_, not other commands (like "git").

I have gotten so used to looking for the former, that I didn't read carefully enough to realize that we are in the latter situation instead.

> Carlo

Thanks, Taylor