Re: [PATCH 1/3] t0033-safe-directory: check the error message without matching the trash dir

From: Taylor Blau <me@ttaylorr.com>
Date: May 9, 2022, 22:27 UTC
Message-ID: <YnmVRoOpfvON6lwW@nand.local>
In-Reply-To: <20220427170649.4949-2-szeder.dev@gmail.com>

On Wed, Apr 27, 2022 at 07:06:47PM +0200, SZEDER Gábor wrote:

Show 5 quoted lines

>   - it is interpreted as a regexp by 'grep', so, because of the dot,
>     it matches the name of the test script and the path of the trash
>     directory as well.  Consequently, these tests could be fooled by
>     any error message that would happen to include the path of the
>     test repository.

Nice catch. I wouldn't have even thought about "could match the test directory" as a potential way for this test to generate a false positive. So I'm happy to see us tightening this down.

Thanks.

Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.