Re: [PATCH v4 1/9] t5326: demonstrate bitmap corruption after permutation

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 26, 2022, 20:18 UTC
Message-ID: <YfGsfdHjYMBb2JWH@nand.local>
In-Reply-To: <220126.8635lafskv.gmgdl@evledraar.gmail.com>

On Wed, Jan 26, 2022 at 04:01:20PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 16 quoted lines

>
> On Tue, Jan 25 2022, Taylor Blau wrote:
>
> > +test_expect_failure 'changing the preferred pack does not corrupt bitmaps' '
> > +	rm -fr repo &&
> > +	git init repo &&
> > +	test_when_finished "rm -fr repo" &&
>
> Nit: The initial "rm -fr" isn't needed here, and we should aim to have
> tests clean up after themselves, not needing to clean up after other
> tests.
>
> This appears to have been copy/pasted from the test you added in
> 54156af0d66 (t5326: test propagating hashcache values, 2021-09-17),
> which needlessly used that pattern, the tests you added preceding it
> follow the "clean up your own mess" pattern.

I don't think I copy/pasted it, but just have it embedded deep into my muscle-memory from every time that I've written:

    rm -fr repo
    git init repo
    cd repo

into $HOME/a.sh, which I use as a dumping ground for little tests.

Yes, I agree it's useless here, but it is consistent with the style (for better or worse).

It's fine if Junio wants to remove it when queueing, but I don't think it's a big enough deal to matter here (probably not in general, either, but I wouldn't be opposed to a concerted effort to clean these up across all of `t` if that's something you're interested in).

Thanks, Taylor