Re: [PATCH v4 1/9] t5326: demonstrate bitmap corruption after permutation

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jan 26, 2022, 15:01 UTC
Message-ID: <220126.8635lafskv.gmgdl@evledraar.gmail.com>
In-Reply-To: <7ea9cced8ec79a8e39948a5e4b8dde6e9b54695a.1643150456.git.me@ttaylorr.com>

On Tue, Jan 25 2022, Taylor Blau wrote:

> +test_expect_failure 'changing the preferred pack does not corrupt bitmaps' '
> +	rm -fr repo &&
> +	git init repo &&
> +	test_when_finished "rm -fr repo" &&

Nit: The initial "rm -fr" isn't needed here, and we should aim to have
tests clean up after themselves, not needing to clean up after other
tests.

This appears to have been copy/pasted from the test you added in 54156af0d66 (t5326: test propagating hashcache values, 2021-09-17), which needlessly used that pattern, the tests you added preceding it follow the "clean up your own mess" pattern.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.