Re: [PATCH v3 0/3] sparse checkout: custom bash completion updates

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 11, 2022, 19:45 UTC
Message-ID: <Yd3eXHzEG7nJi8ZB@nand.local>
In-Reply-To: <92913af3-7985-0789-eee0-c84601d2a31f@gmail.com>

On Tue, Jan 11, 2022 at 09:17:38AM -0800, Lessley Dennington wrote:

Show 12 quoted lines

> On 1/10/22 2:38 PM, Elijah Newren wrote:
> > Other than that one nit, patches 1-2 (and the testcases in patch 3) are:
> >
> > Reviewed-by: Elijah Newren <newren@gmail.com>
> >
> > Since I wrote the new __gitcomp() function in patch 3, it might be
> > nice if we can find another reviewer for it. Especially since I've
> > only lightly touched the completion code and there might be better
> > ways of achieving what I wrote there.
>
> I agree - I'll chat with some folks today to try to find the best person
> to take a look.

Having another set of eyes on this code never hurts, but looking through this file's shortlog (especially with `--since=1.year.ago`), I'm not sure how many active reviewers in this area we still have.

Perhaps the best thing to do would be to grow some new area experts here instead. If I were in Lessley's shoes, I would "think aloud" to make sure I agreed with your implementation for the new `__gitcomp()` function.

If other reviewers happen to be around (perhaps Denton, who I added to the CC) that doesn't hurt either, but short of that...

Thanks, Taylor