Re: [PATCH v2 1/2] sparse-checkout: custom tab completion tests
- From
Elijah Newren <newren@gmail.com>
- Date
- Dec 31, 2021, 22:25 UTC
- Message-ID
- <CABPp-BGKtggHwXF-Xo6ryKCXNq9mgWDHiKz6VfCvrdKxvf0Uug@mail.gmail.com>
- In-Reply-To
- <xmqqy240l8l1.fsf@gitster.g>
On Fri, Dec 31, 2021 at 2:21 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> > Elijah Newren <newren@gmail.com> writes: > > > Second, and this item is unrelated to your series but your comment > > made me realize it....sparse-checkout unfortunately ignores prefix and > > creates a bad .git/info/sparse-checkout file. For example: > > ... > > I think the loss of the current working directory will be fixed by the > > en/keep-cwd directory (currently in next and marked for merging to > > master), but the fact that the wrong paths end up in the > > sparse-checkout file is unfortunate. It basically means that the > > `set` and `add` subcommands of `sparse-checkout` can only be safely > > run from the toplevel directory. > > You made it sound as if this is a fundamental limitation, but it > sounds more like a bug that needs to be fixed (outside the > completion series, of course) to me.
Oh, sorry, I didn't mean to imply that. I meant the same thing you say here: it's another bug we need to fix, in a separate series.