Re: [PATCH v4 1/3] completion: add sparse-checkout tests

From: Elijah Newren <newren@gmail.com>
Date: Jan 28, 2022, 02:04 UTC
Message-ID: <CABPp-BH0ED=6+tcjaxDFypdopH3LtQsDYWbBUW0B9icZjTGMKw@mail.gmail.com>
In-Reply-To: <xmqqtudoy653.fsf@gitster.g>

On Thu, Jan 27, 2022 at 5:56 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

>
> Elijah Newren <newren@gmail.com> writes:
>
> > On Thu, Jan 27, 2022 at 1:21 PM Lessley Dennington via GitGitGadget
> > <gitgitgadget@gmail.com> wrote:
> >>
> >> From: Lessley Dennington <lessleydennington@gmail.com>
> >>
> >> Add tests for missing/incorrect components of custom tab completion for
> >> the sparse-checkout command. These tests specifically highlight the
> >> following:
> >>
> >> 1. git sparse-checkout <TAB> results in an incomplete list of subcommands
> >> (it is missing reapply and add).
> >> 2. git sparse-checkout set <TAB> and git sparse-checkout add <TAB> show
> >> both file names and directory names. While this is the correct behavior
> >
> > s/is/may be/
>
> I would stop at "this may be a less surprising behaviour" without
> going into "correctness".

Ooh, I like that wording even better.

Show 8 quoted lines

> >> +test_expect_success 'non-cone mode sparse-checkout uses bash completion' '
> >> +       # reset sparse-checkout repo to non-cone mode
> >> +       git -C sparse-checkout sparse-checkout disable &&
> >> +       git -C sparse-checkout sparse-checkout set &&
> >
> > Can we add a --no-cone here in preparation for the default to switch?
>
> It would be good to do so, if we plan to switch the default.

We've talked about it for a few cycles, so I created a patch series to do so. But it depends on two or three in-flight series (from Victoria, myself, and now Stolee) to avoid textual conflicts, so I've been waiting for those to settle.