Re: [PATCH 0/2] Use the built-in implementation of the interactive add command by default
- From
Jeff King <peff@peff.net>
- Date
- Nov 30, 2021, 20:56 UTC
- Message-ID
- <YaaP/g74KA63MCmx@coredump.intra.peff.net>
- In-Reply-To
- <pull.1087.git.1638281655.gitgitgadget@gmail.com>
On Tue, Nov 30, 2021 at 02:14:13PM +0000, Johannes Schindelin via GitGitGadget wrote:
Show 7 quoted lines
> Over two years ago, Slavica Đukić participated in the Outreachy project, > starting to implement a built-in version of the interactive git add command. > A little over a year ago, Git turned on that mode whenever users were > running with feature.experimental = true. > > It is time to declare this implementation robust, to use it by default, and > to start deprecating the scripted implementation.
Yay. I agree it is time.
It's still possible there are bugs that feature.experimental folks missed, but at some point we need to flip this switch to get the exposure to find those bugs. Doing it early in a cycle makes sense.
The patches themselves look good to me. I look forward to dropping the perl version entirely, just to reduce the duplicated code, but I think your approach of leaving it as an escape hatch for now makes sense in the shorter term.
-Peff