Re: [PATCH 0/2] Use the built-in implementation of the interactive add command by default

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Dec 1, 2021, 13:43 UTC
Message-ID: <211201.86lf14bfi8.gmgdl@evledraar.gmail.com>
In-Reply-To: <pull.1087.git.1638281655.gitgitgadget@gmail.com>

On Tue, Nov 30 2021, Johannes Schindelin via GitGitGadget wrote:

Show 11 quoted lines

> Over two years ago, Slavica Đukić participated in the Outreachy project,
> starting to implement a built-in version of the interactive git add command.
> A little over a year ago, Git turned on that mode whenever users were
> running with feature.experimental = true.
>
> It is time to declare this implementation robust, to use it by default, and
> to start deprecating the scripted implementation.
>
> Johannes Schindelin (2):
>   t2016: require the PERL prereq only when necessary
>   add -i: default to the built-in implementation

I'm very happy to see this. I left some minor nits on 2/2[1], but with/without those suggested changes this LGTM.

I was a tad surprised that feature.experimental=false doesn't disable this anymore, but after looking into it a bit that's how we should be doing this. I.e. the life cycle for these has been

    opt in setting [&& experimental] -> opt-out setting [&& !experimental] -> remove opt-out

If you're intending to re-roll anyway I think a brief mention of that being intended & correct would be nice.

I.e. I went looking down that rabbit hole since there was no mention of it in the commit message, and wondered if it was intentional & correct, which I then found it is (well, correct, but I'm assuming also intentional).

Thanks!

1. https://lore.kernel.org/git/211201.86pmqgbful.gmgdl@evledraar.gmail.com/