Re: [PATCH 0/2] Use the built-in implementation of the interactive add command by default

From: Carlo Arenas <carenas@gmail.com>
Date: Dec 1, 2021, 21:24 UTC
Message-ID: <CAPUEsphxCcfOgPQP9ci6sSn87g5=w+8kjh21=QywTX=on5vTdw@mail.gmail.com>
In-Reply-To: <pull.1087.git.1638281655.gitgitgadget@gmail.com>

On Wed, Dec 1, 2021 at 12:40 AM Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 6 quoted lines

> It is time to declare this implementation robust, to use it by default, and
> to start deprecating the scripted implementation.
>
> Johannes Schindelin (2):
>   t2016: require the PERL prereq only when necessary
>   add -i: default to the built-in implementation

Sadly this implementation has a few bugs that still need fixing, with at least one IMHO being a showstopper.

The way macOS implements stdin (through a device) it will always timeout in poll(), so escape keys that are left in the unread buffer and that could match some of the entries will result in the wrong entry being selected.

I have a series[1] that reimplements this and that seemed to work fine in my tests while making the code simpler, but that I didn't prioritize (and wanted to clean up further) since I wanted to prioritize the EDITOR fixes in the same area.

Carlo

[1] https://github.com/git/git/pull/1150