git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [ANNOUNCE] Git v2.34.0-rc2

From
Jeff King <peff@peff.net>
Date
Nov 15, 2021, 15:27 UTC
Message-ID
<YZJ8aDNVentnbalp@coredump.intra.peff.net>
In-Reply-To
<YZJ3hZkX9YjNBAdk@ncase>
On Mon, Nov 15, 2021 at 04:06:45PM +0100, Patrick Steinhardt wrote:
Show 7 quoted lines
> Sorry, but I'm currently completely loaded with work and thus didn't
> find the capacity to have a deeper look yet and will probably not find
> the time for a few more days. So the earliest I can have a look at this
> is probably beginning next week.
> 
> With that in mind, I'm happy to have this change reverted for now, as it
> is...

Thanks for chiming in (and again, sorry for bringing this up so late in the cycle).

Show 12 quoted lines
> > > We probably should revert this step as it can affect correctness in
> > > a big way, but I wonder if the other steps in the same series, or
> > > other topic that came later, rely on it.
> > 
> > I looked them over, and I think this is pretty independent (with the
> > exception of the refactoring of the no_walk/unsorted flags, but
> > obviously that had to come first).
> 
> .. completely independent of the other patches in this series and can be
> reverted on its own. Only question is whether we also want to revert the
> patch introducing this option in the first place given that it would end
> up without a user afterwards.

It looks like Junio queued a revert of the whole patch in a7df4f52af (Revert "connected: do not sort input revisions", 2021-11-11), which is on "master". So I think we should have a clean slate to look at this in the next cycle.

-Peff
Previous: Patrick SteinhardtNext: Jeff King
Message 21 of 23 in “[ANNOUNCE] Git v2.34.0-rc2”
  1. Junio C HamanoNov 10, 2021
  2. Jeff KingNov 10, 2021
  3. Jeff KingNov 10, 2021
  4. Carlo ArenasNov 10, 2021
  5. Jeff KingNov 10, 2021
  6. Carlo ArenasNov 10, 2021
  7. Jeff KingNov 10, 2021
  8. RelNotes: mention known crasher when ssh signing with OpenSSH 8.7Carlo Marcelo Arenas Belón, Nov 10, 2021
  9. Junio C HamanoNov 10, 2021
  10. Junio C HamanoNov 10, 2021
  11. Jeff KingNov 11, 2021
  12. Junio C HamanoNov 10, 2021
  13. Johannes AltmanningerNov 10, 2021
  14. Jeff KingNov 10, 2021
  15. Junio C HamanoNov 10, 2021
  16. Jeff KingNov 11, 2021
  17. Junio C HamanoNov 11, 2021
  18. Jeff KingNov 11, 2021
  19. Junio C HamanoNov 11, 2021
  20. Patrick SteinhardtNov 15, 2021
  21. Jeff KingNov 15, 2021
  22. Jeff KingNov 15, 2021
  23. Junio C HamanoNov 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.