Re: [ANNOUNCE] Git v2.34.0-rc2

From: Jeff King <peff@peff.net>
Date: Nov 10, 2021, 08:22 UTC
Message-ID: <YYuBQ2mUCeEmYoLR@coredump.intra.peff.net>
In-Reply-To: <CAPUEspg+NDJFAVcFs2hhcSTORb0Q-Gjcv0M+5tzqXJuBTvbT+Q@mail.gmail.com>

On Wed, Nov 10, 2021 at 12:11:12AM -0800, Carlo Arenas wrote:

Show 10 quoted lines

> On Tue, Nov 9, 2021 at 10:02 PM Jeff King <peff@peff.net> wrote:
> 
> >   - we're not really testing the desired behavior, just looking for a
> >     known-problem. The segfault may get fixed but we'd still have other
> >     bugs.
> 
> This openssh bug was fixed in 8.8 per the release notes; indeed the
> fix[1] (which was misapplied but fixed next commit) looks familiar and
> it is just a straight up crasher, hence unlikely to cause other
> issues.

Ah, thanks for digging. I agree that this is a small isolated bug, so the prereq check I showed would be a good test for it.

IMHO it's worth doing. It looks like 8.7 is the only affected openssh version, but it is likely to cause confusion right when we release.

-Peff