git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] RelNotes: mention known crasher when ssh signing with OpenSSH 8.7

From
Jeff King <peff@peff.net>
Date
Nov 11, 2021, 09:16 UTC
Message-ID
<YYzfhKt7SRT9p8Df@coredump.intra.peff.net>
In-Reply-To
<xmqqmtmbwtim.fsf@gitster.g>
On Wed, Nov 10, 2021 at 02:11:29PM -0800, Junio C Hamano wrote:
Show 29 quoted lines
> >> diff --git a/Documentation/RelNotes/2.34.0.txt b/Documentation/RelNotes/2.34.0.txt
> >> index effab2ea4b..54dcc7240d 100644
> >> --- a/Documentation/RelNotes/2.34.0.txt
> >> +++ b/Documentation/RelNotes/2.34.0.txt
> >> @@ -8,6 +8,9 @@ Backward compatibility notes
> >>  
> >>   * The "--preserve-merges" option of "git rebase" has been removed.
> >>  
> >> + * The upcoming ssh signing feature is broken if used together with
> >> +   OpenSSH 8.7, avoid using it if you cannot update to OpenSSH 8.8
> >> +   (or stay at 8.6)
> >
> > That may be correct, but it is NOT a backward compatibility note.
> 
> So, here is what I plan to do.
> 
> diff --git c/Documentation/RelNotes/2.34.0.txt w/Documentation/RelNotes/2.34.0.txt
> index effab2ea4b..6ed8b92e10 100644
> --- c/Documentation/RelNotes/2.34.0.txt
> +++ w/Documentation/RelNotes/2.34.0.txt
> @@ -77,7 +77,10 @@ UI, Workflows & Features
>   * "git fsck" has been taught to report mismatch between expected and
>     actual types of an object better.
>  
> - * Use ssh public crypto for object and push-cert signing.
> + * In addition to GnuPG, ssh public crypto can be used for object and
> +   push-cert signing.  Note that this feature cannot be used with
> +   ssh-keygen from OpenSSH 8.7, whose support for it is broken.  Avoid
> +   using it unless you update to OpenSSH 8.8.

Attaching to the existing gpg-ssh release note like this makes perfect sense to me. Thanks for tying this one up.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 23 in “[ANNOUNCE] Git v2.34.0-rc2”
  1. Junio C HamanoNov 10, 2021
  2. Jeff KingNov 10, 2021
  3. Jeff KingNov 10, 2021
  4. Carlo ArenasNov 10, 2021
  5. Jeff KingNov 10, 2021
  6. Carlo ArenasNov 10, 2021
  7. Jeff KingNov 10, 2021
  8. RelNotes: mention known crasher when ssh signing with OpenSSH 8.7Carlo Marcelo Arenas Belón, Nov 10, 2021
  9. Junio C HamanoNov 10, 2021
  10. Junio C HamanoNov 10, 2021
  11. Jeff KingNov 11, 2021
  12. Junio C HamanoNov 10, 2021
  13. Johannes AltmanningerNov 10, 2021
  14. Jeff KingNov 10, 2021
  15. Junio C HamanoNov 10, 2021
  16. Jeff KingNov 11, 2021
  17. Junio C HamanoNov 11, 2021
  18. Jeff KingNov 11, 2021
  19. Junio C HamanoNov 11, 2021
  20. Patrick SteinhardtNov 15, 2021
  21. Jeff KingNov 15, 2021
  22. Jeff KingNov 15, 2021
  23. Junio C HamanoNov 13, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.