Re: [PATCH v2 3/4] worktree: sync worktree paths after gitdir move

From: Caleb White <cdwhite3@pm.me>
Date: Oct 6, 2024, 22:41 UTC
Message-ID: <YYay6Jp5c84h3Tx-LViX4teN5KSBX5PL3_WcOFRzUooFrpJpcBD2SRWf1EQjvrMZsI6zkKyPd7JbWt3Ed3OIxCdkg17fY2qvmT4-B6a0RAE=@pm.me>
In-Reply-To: <CAPig+cQApvzpuCBfViPD_hJjqe_poFO8uB1GapeVpCd2EWvEug@mail.gmail.com>

On Sunday, October 6th, 2024 at 06:12, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

> If I understand correctly, this patch is fixing breakage resulting
> from the preceding patch. Unfortunately, this approach is problematic
> since it breaks bisectability of the project. In particular, it's not
> sufficient for the full test suite to pass only at the end of the
> patch series; rather, the entire test suite should continue to pass
> after application of each patch in a series; we don't want one patch
> to break the test suite and a subsequent patch to fix it again.
>
> So, if my understanding is correct, please put some thought into how
> to reorganize this patch series to ensure that the full test suite
> passes for each patch.

Yes, there was one edge case that broke and this patch fixed. But I understand what you mean about the bisectability. I was trying to come up with ways to split up the commits and this seemed like a good spot as it just introduced new functions with minimal changes elsewhere. But this can be squashed into the previous patch.