From: Caleb White Date: Sun, 06 Oct 2024 22:41:33 GMT Subject: Re: [PATCH v2 3/4] worktree: sync worktree paths after gitdir move Message-ID: In-Reply-To: On Sunday, October 6th, 2024 at 06:12, Eric Sunshine wrote: > If I understand correctly, this patch is fixing breakage resulting > from the preceding patch. Unfortunately, this approach is problematic > since it breaks bisectability of the project. In particular, it's not > sufficient for the full test suite to pass only at the end of the > patch series; rather, the entire test suite should continue to pass > after application of each patch in a series; we don't want one patch > to break the test suite and a subsequent patch to fix it again. > > So, if my understanding is correct, please put some thought into how > to reorganize this patch series to ensure that the full test suite > passes for each patch. Yes, there was one edge case that broke and this patch fixed. But I understand what you mean about the bisectability. I was trying to come up with ways to split up the commits and this seemed like a good spot as it just introduced new functions with minimal changes elsewhere. But this can be squashed into the previous patch.