Re: [PATCH v2 1/4] worktree: refactor infer_backlink() to use *strbuf
- From
Caleb White <cdwhite3@pm.me>
- Date
- Oct 7, 2024, 04:31 UTC
- Message-ID
- <vkneUltI5q9qajOYcG8GYE8FHCRIJbH1ExR58YoEm9pam2_L6LlchL4otU6jk6l7iIN0kjOWtknZx4aCxRjGTVicQ69RmOYt_RUghGlV4hA=@pm.me>
- In-Reply-To
- <ZwNjgvMbUKgpbP7O@ArchLinux>
On Sunday, October 6th, 2024 at 23:28, shejialuo <shejialuo@gmail.com> wrote:
Show 5 quoted lines
> > } else if (err) {
> > fn(1, realdotgit.buf, _("unable to locate repository; .git file broken"), cb_data);
> > goto done;
> > }
> >
> Thanks, you are correct here. We cannot use "BUG" here. And I think > currently this is OK.
Granted, that last `else if` could just become an `else` statement now, I'll make that change.