Re: [PATCH v6 03/22] cat-file tests: test for missing object with -t and -s

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 16, 2021, 20:01 UTC
Message-ID: <YUOipZRE8tu+n8H6@nand.local>
In-Reply-To: <YUOhqnj7vwr00Qap@nand.local>

On Thu, Sep 16, 2021 at 03:57:30PM -0400, Taylor Blau wrote:

Show 9 quoted lines

> On Tue, Sep 07, 2021 at 12:57:58PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > Test for what happens when the -t and -s flags are asked to operate on
> > a missing object, this extends tests added in 3e370f9faf0 (t1006: add
> > tests for git cat-file --allow-unknown-type, 2015-05-03). The -t and
> > -s flags are the only ones that can be combined with
> > --allow-unknown-type, so let's test with and without that flag.
>
> I'm a little skeptical to have tests for all four pairs of `-t` or `-s`
> and "with `--allow-unknown-type` and without `--allow-unknown-type`".

Ah. Reading the next patch makes me feel even more certain of this advice. Consider squashing this and the next patch with my suggestion to use a loop below?

Thanks, Taylor