Re: [PATCH v6 10/22] object-file.c: make parse_loose_header_extended() public

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 16, 2021, 21:39 UTC
Message-ID: <YUO5m9gukagBGiF3@nand.local>
In-Reply-To: <patch-v6-10.22-b15ad53414b-20210907T104559Z-avarab@gmail.com>

On Tue, Sep 07, 2021 at 12:58:05PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> Make the parse_loose_header_extended() function public and remove the
> parse_loose_header() wrapper. The only direct user of it outside of
> object-file.c itself was in streaming.c, that caller can simply pass
> the required "struct object-info *" instead.
>
> This change is being done in preparation for teaching
> read_loose_object() to accept a flag to pass to
> parse_loose_header(). It isn't strictly necessary for that change, we
> could simply use parse_loose_header_extended() there, but will leave
> the API in a better end state.

All seems reasonable. I agree that this is not a necessary step, but at least the clean-up is self contained and an easy enough read.

The flag that read_loose_object() is going to start passing to parse_loose_header() is left a bit vague, but I'll continue reading to figure out what it is.

Thanks, Taylor