Re: [PATCH v6 13/22] object-file.c: split up ternary in parse_loose_header()

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 16, 2021, 21:58 UTC
Message-ID: <YUO97RoOzY639hYW@nand.local>
In-Reply-To: <patch-v6-13.22-90489d9e6ec-20210907T104559Z-avarab@gmail.com>

On Tue, Sep 07, 2021 at 12:58:08PM +0200, Ævar Arnfjörð Bjarmason wrote:

> This minor formatting change serves to make a subsequent patch easier
> to read.

Hmm. I'm not sure if I agree.

As far as I can tell from reading the subsequent patch, this is designed to make it easier to add a comment above "return type" that pertains just to the case when !*hdr.

I think it would have been fine to go from the ternary to this style with the comment in a single patch. But I also think it would have been fine to add the comment above the ternary and instead start it off by saying "when !*hdr, ...".

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.