Re: [PATCH v4 0/8] rev-list: implement object type filter

From: Jeff King <peff@peff.net>
Date: Apr 17, 2021, 08:58 UTC
Message-ID: <YHqjHA6ZUYvT6w1T@coredump.intra.peff.net>
In-Reply-To: <xmqq8s5jsa5c.fsf@gitster.g>

On Thu, Apr 15, 2021 at 10:57:51AM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > ...  But that leads me to
> > wonder into a different direction---coalesce (tag|tree|blob)_objects
> > members into a single bit, say all_objects, have "--objects" and
> > friends set that single bit, and update places like these to check
> > that single bit.
> 
> Just to avoid misunderstanding, I am not saying this topic needs to
> address any of this unifying of three bits.
> 
> It is just an idea for those interested to think about, when they
> have nothing better to do, when the codebase is quiescent.

It does feel like going "backwards" in a sense. We have the three flags mostly split, and we'd lose that distinction. On the other hand, if the current split is imperfect, it may be leading people down a confusing path (I _think_ this "trees must be set in order to see blobs" thing is the only real gotcha, but there could be others).

There's some other discussion in this old thread:

  https://lore.kernel.org/git/06a84f8c77924b275606384ead8bb2fd7d75f7b6.1487984670.git.jonathantanmy@google.com/

(I didn't remember it, but my spider sense tingling caused me to dig in the archive a bit).

-Peff