Re: [PATCH v4 0/8] rev-list: implement object type filter

From: Jeff King <peff@peff.net>
Date: Apr 13, 2021, 07:45 UTC
Message-ID: <YHVMEdeDv9ZeXRAU@coredump.intra.peff.net>
In-Reply-To: <cover.1618234575.git.ps@pks.im>

On Mon, Apr 12, 2021 at 03:37:14PM +0200, Patrick Steinhardt wrote:

Show 18 quoted lines

> this is the fourth version of my patch series which implements a new
> `object:type` filter for git-rev-list(1) and git-upload-pack(1) and
> extends support for bitmap indices to work with combined filters.
> 
> Changes compared to v3:
> 
>     - Small style fix to not pass an empty string and `0`, but instead
>       simply pass two `NULL` pointers to
>       `list_objects_filter__filter_object, pointed out by Junio.
> 
>     - I've changed patch 7/8 as proposed by Peff: support of combined
>       filters is now determined directly in `filter_bitmap()`, without
>       having to mirror all filter types in the new `filter_supported()`
>       function.
> 
>     - Renamed `--filter-provided-revisions` to
>       `--filter-provided-objects` as proposed by Peff and addressed both
>       commit message and tests as pointed out by Philip.

Thanks. I have no more nits to pick. The only question left for me is the big one of "do we like this with --filter, or should it be some kind of rev-list option", as discussed in:

  https://lore.kernel.org/git/YHB7R8hVRt+V+i2W@coredump.intra.peff.net/

As I said elsewhere, I'm OK going with this route. I just wanted to call attention to that earlier response in case you had any final thoughts (I'm guessing your final thoughts are "jeez, I already wrote it with --filter, so let's just go with that" which is perfectly reasonable to me. ;) ).

-Peff