git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/8] rev-list: implement object type filter

From
Jeff King <peff@peff.net>
Date
Apr 15, 2021, 09:42 UTC
Message-ID
<YHgKiXRMq/1Fpg2x@coredump.intra.peff.net>
In-Reply-To
<YHVQ9RPLk8/r+8mS@ncase>
On Tue, Apr 13, 2021 at 10:06:13AM +0200, Patrick Steinhardt wrote:
Show 17 quoted lines
> I don't think it would help usability to add new `--show-blobs` and
> `--show-trees` options. The user interface to show this kind of
> information exists already with `--objects`, and by adding another way
> of asking a similar query would raise the question of how these two ways
> interact with each other:
> 
>     - Does `--show-blobs` have effect if `--objects` is not set?
> 
>     - Is `--objects` redundant if we have `--show-blobs`, or would
>       `--objects --show-blobs` list all objects regardless of whether
>       they're blobs or not?
> 
>     - What would happen if the user says `--show-blobs --no-objects`?
> 
>     - Are these options mutually exclusive?
> 
> We avoid all these questions by just adding it as a filter.

I'm not too worried about those. I'd imagine that "--objects" becomes a documented synonym for "--show-trees --show-blobs --show-commits --show-tags", and then the usual interactions take over.

But...
Show 7 quoted lines
> Furthermore, the filter also allows future iterations which build on top
> of this. If we had a combined OR filter in addition to the existing
> combined AND filter, the user could say "Give me all blobs which aren't
> bigger than a specific size PLUS all trees with a depth smaller than 5
> PLUS all commits and tags". It's not like I'd know of a specific usecase
> for this right now, but I think the potential of having such filters in
> the future is a plus.

Yeah, that's true. My biggest complaint is lack of an OR filter, but we could add that later. And then we would be _more_ flexible, as you note, since we could and/or more filters.

So I'm OK proceeding with this direction.
-Peff
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 73 of 97 in “rev-parse: implement object type filter”
  1. 0/7 rev-parse: implement object type filterPatrick Steinhardt, Mar 1, 2021
  2. 3/7 list-objects: support filtering by tag and commitPatrick Steinhardt, Mar 1, 2021
  3. 4/7 list-objects: implement object type filterPatrick Steinhardt, Mar 1, 2021
  4. 1/7 revision: mark commit parents as NOT_USER_GIVENPatrick Steinhardt, Mar 1, 2021
  5. 2/7 list-objects: move tag processing into its own functionPatrick Steinhardt, Mar 1, 2021
  6. 6/7 pack-bitmap: implement combined filterPatrick Steinhardt, Mar 1, 2021
  7. 5/7 pack-bitmap: implement object type filterPatrick Steinhardt, Mar 1, 2021
  8. 7/7 rev-list: allow filtering of provided itemsPatrick Steinhardt, Mar 1, 2021
  9. Jeff KingMar 10, 2021
  10. Patrick SteinhardtMar 11, 2021
  11. Jeff KingMar 11, 2021
  12. Patrick SteinhardtMar 15, 2021
  13. Taylor BlauMar 10, 2021
  14. Jeff KingMar 10, 2021
  15. Patrick SteinhardtMar 11, 2021
  16. Jeff KingMar 11, 2021
  17. 0/8 rev-parse: implement object type filterPatrick Steinhardt, Mar 15, 2021
  18. 1/8 uploadpack.txt: document implication of `uploadpackfilter.allow`Patrick Steinhardt, Mar 15, 2021
  19. Jeff KingApr 6, 2021
  20. 2/8 revision: mark commit parents as NOT_USER_GIVENPatrick Steinhardt, Mar 15, 2021
  21. Jeff KingApr 6, 2021
  22. Patrick SteinhardtApr 9, 2021
  23. 4/8 list-objects: support filtering by tag and commitPatrick Steinhardt, Mar 15, 2021
  24. 3/8 list-objects: move tag processing into its own functionPatrick Steinhardt, Mar 15, 2021
  25. Jeff KingApr 6, 2021
  26. 5/8 list-objects: implement object type filterPatrick Steinhardt, Mar 15, 2021
  27. Jeff KingApr 6, 2021
  28. 7/8 pack-bitmap: implement combined filterPatrick Steinhardt, Mar 15, 2021
  29. Jeff KingApr 6, 2021
  30. Patrick SteinhardtApr 9, 2021
  31. Jeff KingApr 9, 2021
  32. Patrick SteinhardtApr 9, 2021
  33. Jeff KingApr 9, 2021
  34. 8/8 rev-list: allow filtering of provided itemsPatrick Steinhardt, Mar 15, 2021
  35. Jeff KingApr 6, 2021
  36. Patrick SteinhardtApr 9, 2021
  37. Jeff KingApr 9, 2021
  38. 6/8 pack-bitmap: implement object type filterPatrick Steinhardt, Mar 15, 2021
  39. Jeff KingApr 6, 2021
  40. Junio C HamanoMar 20, 2021
  41. Jeff KingApr 6, 2021
  42. Patrick SteinhardtApr 9, 2021
  43. Jeff KingApr 9, 2021
  44. 0/8 rev-parse: implement object type filterPatrick Steinhardt, Apr 9, 2021
  45. 1/8 uploadpack.txt: document implication of `uploadpackfilter.allow`Patrick Steinhardt, Apr 9, 2021
  46. 2/8 revision: mark commit parents as NOT_USER_GIVENPatrick Steinhardt, Apr 9, 2021
  47. 3/8 list-objects: move tag processing into its own functionPatrick Steinhardt, Apr 9, 2021
  48. 4/8 list-objects: support filtering by tag and commitPatrick Steinhardt, Apr 9, 2021
  49. Junio C HamanoApr 11, 2021
  50. 5/8 list-objects: implement object type filterPatrick Steinhardt, Apr 9, 2021
  51. 6/8 pack-bitmap: implement object type filterPatrick Steinhardt, Apr 9, 2021
  52. 7/8 pack-bitmap: implement combined filterPatrick Steinhardt, Apr 9, 2021
  53. 8/8 rev-list: allow filtering of provided itemsPatrick Steinhardt, Apr 9, 2021
  54. 8/8 rev-list: allow filtering of provided itemsPatrick Steinhardt, Apr 9, 2021
  55. Philip OakleyApr 9, 2021
  56. Patrick SteinhardtApr 12, 2021
  57. Junio C HamanoApr 11, 2021
  58. Patrick SteinhardtApr 12, 2021
  59. 0/8 rev-list: implement object type filterPatrick Steinhardt, Apr 12, 2021
  60. 1/8 uploadpack.txt: document implication of `uploadpackfilter.allow`Patrick Steinhardt, Apr 12, 2021
  61. 2/8 revision: mark commit parents as NOT_USER_GIVENPatrick Steinhardt, Apr 12, 2021
  62. 3/8 list-objects: move tag processing into its own functionPatrick Steinhardt, Apr 12, 2021
  63. 4/8 list-objects: support filtering by tag and commitPatrick Steinhardt, Apr 12, 2021
  64. 5/8 list-objects: implement object type filterPatrick Steinhardt, Apr 12, 2021
  65. Ævar Arnfjörð BjarmasonApr 13, 2021
  66. Andreas SchwabApr 13, 2021
  67. Patrick SteinhardtApr 14, 2021
  68. 6/8 pack-bitmap: implement object type filterPatrick Steinhardt, Apr 12, 2021
  69. 7/8 pack-bitmap: implement combined filterPatrick Steinhardt, Apr 12, 2021
  70. 8/8 rev-list: allow filtering of provided itemsPatrick Steinhardt, Apr 12, 2021
  71. Jeff KingApr 13, 2021
  72. Patrick SteinhardtApr 13, 2021
  73. Jeff KingApr 15, 2021
  74. Junio C HamanoApr 16, 2021
  75. Junio C HamanoApr 16, 2021
  76. Ramsay JonesApr 17, 2021
  77. Jeff KingApr 17, 2021
  78. Junio C HamanoApr 17, 2021
  79. Junio C HamanoApr 13, 2021
  80. Patrick SteinhardtApr 14, 2021
  81. Junio C HamanoApr 14, 2021
  82. Jeff KingApr 15, 2021
  83. Junio C HamanoApr 15, 2021
  84. Junio C HamanoApr 15, 2021
  85. Jeff KingApr 17, 2021
  86. 0/8 rev-list: implement object type filterPatrick Steinhardt, Apr 19, 2021
  87. 1/8 uploadpack.txt: document implication of `uploadpackfilter.allow`Patrick Steinhardt, Apr 19, 2021
  88. 2/8 revision: mark commit parents as NOT_USER_GIVENPatrick Steinhardt, Apr 19, 2021
  89. 3/8 list-objects: move tag processing into its own functionPatrick Steinhardt, Apr 19, 2021
  90. 4/8 list-objects: support filtering by tag and commitPatrick Steinhardt, Apr 19, 2021
  91. 5/8 list-objects: implement object type filterPatrick Steinhardt, Apr 19, 2021
  92. 7/8 pack-bitmap: implement combined filterPatrick Steinhardt, Apr 19, 2021
  93. 6/8 pack-bitmap: implement object type filterPatrick Steinhardt, Apr 19, 2021
  94. 8/8 rev-list: allow filtering of provided itemsPatrick Steinhardt, Apr 19, 2021
  95. Junio C HamanoApr 19, 2021
  96. Jeff KingApr 23, 2021
  97. Junio C HamanoApr 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.