Re: [PATCH v2 0/3] config: allow overriding global/system config

From: Jeff King <peff@peff.net>
Date: Apr 9, 2021, 15:41 UTC
Message-ID: <YHB1n+d/60MaQjsH@coredump.intra.peff.net>
In-Reply-To: <cover.1617975637.git.ps@pks.im>

On Fri, Apr 09, 2021 at 03:43:16PM +0200, Patrick Steinhardt wrote:

> Instead of going for GIT_CONFIG_NOGLOBAL, I've adopted Junio's proposal
> of going with GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM, which allow a
> user to modify the locations of those files. Thanks for the discussion,
> this solution feels a lot nicer to me!

Thanks, I like this much better. I left a few comments on the patches themselves. Mostly small suggestions, but design-wise I'm of the opinion we should drop the "file must exist" requirement; see the response to patch 3.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.