Re: [PATCH v4 0/3] config: allow overriding global/system config
On Tue, Apr 13, 2021 at 10:49:40AM -0700, Junio C Hamano wrote:
Show 29 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
>
> > Compared to v3, I only dropped the special-casing of `/dev/null`. As
> > Junio rightly pointed out, the special-casing was incomplete and would
> > have required more work to do the right thing for all cases. It can
> > still be re-added at a later point if the usecase actually comes up.
> >
> > Patrick
> >
> > Patrick Steinhardt (3):
> > config: rename `git_etc_config()`
> > config: unify code paths to get global config paths
> > config: allow overriding of global and system configuration
> >
> > Documentation/git-config.txt | 5 +++
> > Documentation/git.txt | 10 +++++
> > builtin/config.c | 6 +--
> > config.c | 41 +++++++++++++++------
> > config.h | 4 +-
> > t/t1300-config.sh | 71 ++++++++++++++++++++++++++++++++++++
> > 6 files changed, 121 insertions(+), 16 deletions(-)
>
> This round looks good to me. Sorry for suggesting the "/dev/null"
> thing in the first place to lead you into wild goose chase during
> the last round.
>
> Will queue. Thanks for working on it.
>
> And thanks for reviewing, everybody.
No worries, and thanks a lot for all the feedback!
Patrick