From: Jeff King Date: Fri, 09 Apr 2021 15:41:19 GMT Subject: Re: [PATCH v2 0/3] config: allow overriding global/system config Message-ID: In-Reply-To: On Fri, Apr 09, 2021 at 03:43:16PM +0200, Patrick Steinhardt wrote: > Instead of going for GIT_CONFIG_NOGLOBAL, I've adopted Junio's proposal > of going with GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM, which allow a > user to modify the locations of those files. Thanks for the discussion, > this solution feels a lot nicer to me! Thanks, I like this much better. I left a few comments on the patches themselves. Mostly small suggestions, but design-wise I'm of the opinion we should drop the "file must exist" requirement; see the response to patch 3. -Peff